Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql: add support for tx types and tx access lists #22491

Merged
merged 7 commits into from
Apr 6, 2021
Merged

graphql: add support for tx types and tx access lists #22491

merged 7 commits into from
Apr 6, 2021

Conversation

AmitBRD
Copy link
Contributor

@AmitBRD AmitBRD commented Mar 12, 2021 •
edited
Loading

fixes #22487 this PR adds the ability to query the type and AccessTuple from graphql endpoint

@AmitBRD AmitBRD requested a review from gballet as a code owner March 12, 2021 19:09
holiman
holiman reviewed Mar 13, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR!

In addition to the inlined comments, we would need some testcases for this, alongside the existing graphql tests.

graphql/graphql.go Show resolved Hide resolved
graphql/graphql.go Outdated Show resolved Hide resolved
graphql/graphql.go Show resolved Hide resolved
@AmitBRD AmitBRD requested a review from holiman March 29, 2021 17:33
@fjl fjl added this to the 1.10.2 milestone Apr 6, 2021
@fjl fjl self-assigned this Apr 6, 2021
@fjl fjl changed the title Add Support to query Type and AccessList from Graphql graphql: add support for tx types and tx access lists Apr 6, 2021
fjl
fjl approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this using

{
  block (number:8314243) {
    number
    transactions {
      type
      accessList {
        address
        storageKeys
      }
    }
  }
}

and it works on Rinkeby.

@fjl fjl merged commit adf09ae into ethereum:master Apr 6, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@AmitBRD @AmitShah
@fjl @atif-konasl
graphql: add support for tx types and tx access lists (ethereum#22491)
bbd79b4 
This adds support for EIP-2718 access list transactions in the GraphQL API.

Co-authored-by: Amit Shah <[email protected]>
Co-authored-by: Felix Lange <[email protected]>
@quorumbot quorumbot mentioned this pull request Apr 28, 2022
Merged
9 tasks
@gzliudan gzliudan mentioned this pull request Apr 22, 2024
Merged
18 tasks
@gzliudan gzliudan mentioned this pull request May 17, 2024
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

@gballet gballet Awaiting requested review from gballet

@holiman holiman Awaiting requested review from holiman

Assignees

@fjl fjl

Labels
None yet
Projects
None yet
Milestone
1.10.2
Development

Successfully merging this pull request may close these issues.

GraphQL schema is not EIP-2718/EIP-2930 aware
4 participants
@AmitBRD @fjl @holiman @AmitShah